Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: display Not purchasable notice for own product #2070

Conversation

shohag121
Copy link
Member

@shohag121 shohag121 commented Nov 2, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Related Pull Request(s)

Closes

How to test the changes in this Pull Request:

  • Steps or issue link

Changelog entry

update: display Not purchasable notice for own product

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@shohag121 shohag121 self-assigned this Nov 2, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Nov 2, 2023
@shashwatahalder01
Copy link
Contributor

shashwatahalder01 commented Nov 2, 2023

Scenario:
kindly, remove the "As this is your own product, the "Add to Cart" button..." message for the auction product or vice-versa. Only one message is sufficient.

Screenshot at Nov 02 14-54-02

@shohag121
Copy link
Member Author

Scenario: kindly, remove the "As this is your own product, the "Add to Cart" button..." message for the auction product or vice-versa. Only one message is sufficient.

Screenshot at Nov 02 14-54-02

@shashwatahalder01 Can you check now?

@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team and removed Type: Bug labels Nov 2, 2023
@nurul-umbhiya nurul-umbhiya merged commit 1ea726c into getdokan:develop Nov 10, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Products] QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants